This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch]: Add endianess to valprint routines
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: deuling at de dot ibm dot com (Markus Deuling)
- Cc: gdb-patches at sourceware dot org (GDB Patches)
- Date: Wed, 21 May 2008 17:14:32 +0200 (CEST)
- Subject: Re: [patch]: Add endianess to valprint routines
Markus Deuling wrote:
> * valprint.c (print_hex_chars, print_octal_chars, print_decimal_chars,
> print_binary_chars, print_char_chars): Add byte_order parameter and
> replace gdbarch_byte_order.
> (print_decimal_chars): Replace START_P, NOT_END_P and NEXT_P by their
> expressions and remove them. Remove unused TWO_TO_FOURTH.
> (val_print_type_code_int): Introduce gdbarch_byte_order to get at the
> endianness. Update call to print_hex_chars.
> * valprint.h (print_hex_chars, print_octal_chars, print_decimal_chars,
> print_binary_chars, print_char_chars): Add byte_order parameter.
> * printcmd.c (print_scalar_formatted): Introduce gdbarch_byte_order to
> get at the endianness. Update print_*_char calls to use byte_order.
Minor coding style issue in the ChangeLog: please always use two spaces
after '.'.
Otherwise, this is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com