This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] [2/2] Remove SYMTAB argument from lookup_symbol functions
- From: Pedro Alves <pedro_alves at portugalmail dot pt>
- To: gdb-patches at sourceware dot org
- Cc: "Ulrich Weigand" <uweigand at de dot ibm dot com>, Joel Brobecker <brobecker at adacore dot com>
- Date: Mon, 19 May 2008 19:38:03 +0100
- Subject: Re: [rfc] [2/2] Remove SYMTAB argument from lookup_symbol functions
- References: <200805191620.m4JGK4xa019782@d12av02.megacenter.de.ibm.com>
A Monday 19 May 2008 17:20:04, Ulrich Weigand wrote:
> I've checked both cleanup patches in now.
Thanks Ulrich! I've applied this patch to remove reference to the
symtab arg in a few places I noticed got left behind.
--
Pedro Alves
2008-05-19 Pedro Alves <pedro@codesourcery.com>
* symtab.h (lookup_symbol_in_language): Update comment.
* symtab.c (lookup_symbol_aux_block): Update comment.
* ada-lang.c (ada_lookup_symbol_list): Update comment.
---
gdb/ada-lang.c | 2 +-
gdb/symtab.c | 6 ++----
gdb/symtab.h | 2 +-
3 files changed, 4 insertions(+), 6 deletions(-)
Index: src/gdb/symtab.h
===================================================================
--- src.orig/gdb/symtab.h 2008-05-19 19:03:16.000000000 +0100
+++ src/gdb/symtab.h 2008-05-19 19:03:59.000000000 +0100
@@ -1006,7 +1006,7 @@ int symbol_matches_domain (enum language
extern struct symtab *lookup_symtab (const char *);
-/* lookup a symbol by name (optional block, optional symtab) in language */
+/* lookup a symbol by name (optional block) in language. */
extern struct symbol *lookup_symbol_in_language (const char *,
const struct block *,
Index: src/gdb/symtab.c
===================================================================
--- src.orig/gdb/symtab.c 2008-05-19 19:03:17.000000000 +0100
+++ src/gdb/symtab.c 2008-05-19 19:03:59.000000000 +0100
@@ -1169,8 +1169,6 @@ fixup_psymbol_section (struct partial_sy
/* Find the definition for a specified symbol name NAME
in domain DOMAIN, visible from lexical block BLOCK.
Returns the struct symbol pointer, or zero if no symbol is found.
- If SYMTAB is non-NULL, store the symbol table in which the
- symbol was found there, or NULL if not found.
C++: if IS_A_FIELD_OF_THIS is nonzero on entry, check to see if
NAME is a field of the current implied argument `this'. If so set
*IS_A_FIELD_OF_THIS to 1, otherwise set it to zero.
@@ -1399,8 +1397,8 @@ lookup_objfile_from_block (const struct
return NULL;
}
-/* Look up a symbol in a block; if found, locate its symtab, fixup the
- symbol, and set block_found appropriately. */
+/* Look up a symbol in a block; if found, fixup the symbol, and set
+ block_found appropriately. */
struct symbol *
lookup_symbol_aux_block (const char *name, const char *linkage_name,
Index: src/gdb/ada-lang.c
===================================================================
--- src.orig/gdb/ada-lang.c 2008-05-19 19:13:18.000000000 +0100
+++ src/gdb/ada-lang.c 2008-05-19 19:13:31.000000000 +0100
@@ -4666,7 +4666,7 @@ remove_irrelevant_renamings (struct ada_
/* Find symbols in DOMAIN matching NAME0, in BLOCK0 and enclosing
scope and in global scopes, returning the number of matches. Sets
- *RESULTS to point to a vector of (SYM,BLOCK,SYMTAB) triples,
+ *RESULTS to point to a vector of (SYM,BLOCK) tuples,
indicating the symbols found and the blocks and symbol tables (if
any) in which they were found. This vector are transient---good only to
the next call of ada_lookup_symbol_list. Any non-function/non-enumeral