This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Remove addr, endaddr, offset from obj_section


Pedro Alves wrote:

> I've been meaning to test this on Cygwin/MinGW/Dwarf before
> posting, but since the subject came up, here it goes anyway.

Thanks!

>   I seems the comment is a bit offbase.  The reader still applies
>   ANOFFSET to the symbols, so psymtab->symtab expansion time sees
>   the correct section offsets.  It feels like the xcoff reader 
>   should cope with the section offsets != 0 internally, and not
>   do this ignoring, but since I don't have access to any AIX system, 
>   I didn't investigate that further.  But I do think things should
>   still work as they used to.

I haven't looked into the patch in detail, but just one comment here:
The guard on this block of code is
#ifndef DEPRECATED_IBM6000_TARGET
so it is executed on every target *but* AIX.  Removing it doesn't 
change the behaviour on AIX, so there should be no need to specially
test on AIX.

(In any case, I'll be happy to test patches on AIX if necessary.)


Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]