This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix calls to frame_base_find_by_frame in frame.c (?)
- From: Daniel Jacobowitz <drow at false dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 8 May 2008 22:34:36 -0400
- Subject: Re: [RFA] Fix calls to frame_base_find_by_frame in frame.c (?)
- References: <20080509022413.GO7421@adacore.com>
On Thu, May 08, 2008 at 07:24:13PM -0700, Joel Brobecker wrote:
> Hi Daniel,
>
> I noticed a regression while converting alpha-osf to the value-based
> unwinding approach, and it looks like frame_base_find_by_frame was
> changed to take a this_frame but the callers were still left passing
> a next_frame. As a result, we ended up selecting the wrong frame
> base unwinder for a one of our frames, leading to the wrong value
> being printed for the one argument.
>
> 2008-05-08 Joel Brobecker <brobecker@adacore.com>
>
> * frame.c (get_frame_base_address, get_frame_locals_address)
> (get_frame_args_address): Pass the correct frame when calling
> frame_base_find_by_frame.
Yes, you're right. OK, thanks.
--
Daniel Jacobowitz
CodeSourcery