This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfa] gdbserver multiple register set issue: PBUFSIZ
- From: Daniel Jacobowitz <drow at false dot org>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 8 May 2008 14:57:51 -0400
- Subject: Re: [rfa] gdbserver multiple register set issue: PBUFSIZ
- References: <200805081828.m48ISqlb004187@d12av02.megacenter.de.ibm.com>
On Thu, May 08, 2008 at 08:28:52PM +0200, Ulrich Weigand wrote:
> I guess one way to fix this would be to have GDB issue another qSupported
> query after it re-attaches. On the other hand, I'm not sure why this
> parameter is even limited by the register set size: when transferring
> memory or files (or other data like XML feature descriptions), allowing
> larger packet sizes would be helpful even on platforms where the register
> set is small.
Right. It used to be that PBUFSIZ was much larger than any packet
we'd have reason to send except for g/G, but that's not true any more;
now there's bulk memory transfers and XML.
> As GDB limits the packet size to 16 KB anyway, I'd propose to simply
> always use 16 KB as PBUFSIZ as well. The patch below implements this
> (together with a sanity check that register packets still fit).
>
> Tested on powerpc-linux and powerpc64-linux in local gdbserver mode.
>
> What do you think? OK for mainline?
OK, thanks.
--
Daniel Jacobowitz
CodeSourcery