This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] 09/10 Add "continue --all"
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 08 May 2008 14:42:51 +0300
- Subject: Re: [RFC] 09/10 Add "continue --all"
- References: <200805061649.50105.pedro@codesourcery.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Tue, 6 May 2008 16:49:50 +0100
>
> + if (args != NULL)
> + {
> + if (strncmp (args, "--all", 5) == 0)
Can we please void literal constants like 5 here? sizeof should be
our friend, and you actually use it 3 lines below this:
> + {
> + all_threads = 1;
> + args += sizeof ("--all") - 1;
> + if (*args == '\0')
> + args = NULL;
> + }