This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Entry point update with "run" command
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Daniel Jacobowitz <drow at false dot org>
- Date: Sun, 4 May 2008 16:36:14 +0200
- Subject: Re: [RFC] Entry point update with "run" command
- References: <1209052694.18229.6.camel@gargoyle.br.ibm.com> <20080426132225.GA16017@host0.dyn.jankratochvil.net> <20080502154447.GR29202@caradoc.them.org>
On Fri, 02 May 2008 17:44:47 +0200, Daniel Jacobowitz wrote:
> On Sat, Apr 26, 2008 at 03:22:25PM +0200, Jan Kratochvil wrote:
> > There is a problem whole EXEC_BFD becomes stale - using the more general
> > attached patch.
>
> Does this work if you just call exec_file_attach instead of
> exec_ops.to_open? The difference is target_preopen which I do not
> believe we want here.
Thanks, it works (I was tryint to use exec_file_command instead before).
> If that works, it's OK to commit.
Committed, no regressions on native x86_64-unknown-linux-gnu.
Regards,
Jan
2008-05-04 Jan Kratochvil <jan.kratochvil@redhat.com>
* symfile.c (reread_symbols): Reload EXEC_BFD on its change.
===================================================================
RCS file: /cvs/src/src/gdb/symfile.c,v
retrieving revision 1.201
retrieving revision 1.202
diff -u -r1.201 -r1.202
--- src/gdb/symfile.c 2008/05/04 03:45:42 1.201
+++ src/gdb/symfile.c 2008/05/04 14:34:06 1.202
@@ -2331,6 +2331,14 @@
/* We need to do this whenever any symbols go away. */
make_cleanup (clear_symtab_users_cleanup, 0 /*ignore*/);
+ if (exec_bfd != NULL && strcmp (bfd_get_filename (objfile->obfd),
+ bfd_get_filename (exec_bfd)) == 0)
+ {
+ /* Reload EXEC_BFD without asking anything. */
+
+ exec_file_attach (bfd_get_filename (objfile->obfd), 0);
+ }
+
/* Clean up any state BFD has sitting around. We don't need
to close the descriptor but BFD lacks a way of closing the
BFD without closing the descriptor. */