This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Report the main thread.
Vladimir Prus wrote:
> Daniel Jacobowitz wrote:
>
>> On Sat, Apr 26, 2008 at 08:44:23PM +0400, Vladimir Prus wrote:
>>> Will some approach that only produce MI output be fine with you?
>>
>> Perhaps that means any observer for a new MI thread should go in
>> add_thread_silent?
>
> Yes, moving the observer call to add_thread_silent is the most
> direct approach to make MI work the way I want without disturbing CLI.
Here's a patch to that effect. OK?
* thread.c (add_thread): Move observer call to ...
(add_thread_silent): ... here.
---
gdb/thread.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/gdb/thread.c b/gdb/thread.c
index 46e6ba7..d3cfb32 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -124,6 +124,9 @@ add_thread_silent (ptid_t ptid)
tp->num = ++highest_thread_num;
tp->next = thread_list;
thread_list = tp;
+
+ observer_notify_new_thread (tp);
+
return tp;
}
@@ -136,8 +139,6 @@ add_thread_with_info (ptid_t ptid, struct private_thread_info *private)
if (print_thread_events)
printf_unfiltered (_("[New %s]\n"), target_pid_to_str (ptid));
-
- observer_notify_new_thread (result);
return result;
}