This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Remove exec_set_section_offsets


On Fri, 2008-04-18 at 18:58 -0700, Joel Brobecker wrote:
> > Perhaps it would qualify as obvious, but I'm not used to removing code
> > from GDB so better ask about it...
> 
> We just have to remember that insight builds on top of GDB. So, just
> to be absolutely sure, I checked out the insight sources, and verified
> that it wasn't using that function. So far, the functions I've seen
> being used by insight started with a gdb_ prefix, but that might not
> be a rule.

Nice to know, thanks for the tip. So if I observe that, this kind of
patch fits the obvious rule?

> > 2008-04-18  Thiago Jung Bauermann  <bauerman@br.ibm.com>
> > 
> > 	* defs.h (exec_set_section_offsets): Remove prototype.
> > 	* exec.c (exec_set_section_offsets): Remove function.
> 
> That's OK. Thank you!

Committed, thanks!
-- 
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]