Re: [RFA] mixed source+assembly from cli disassemble

[Michael Snyder <msnyder at specifix dot com>]

On Thu, 2008-04-10 at 16:13 -0700, Michael Snyder wrote:
> On Thu, 2008-04-10 at 01:15 -0700, Joel Brobecker wrote:
> > > Going on a week...
> > > No other comments, pro or con?
> > 
> > I really like the idea, it's something that I often wished we'd have
> > (and often asked for in graphical front-ends). I was going to review
> > the patch, but wanted to ask others to comment on the user interface
> > first. Once we agree on the syntax, then I can review the patch itself.
> > 
> > Doug suggests to use an optional "/s" modifier. For instance:
> > 
> >    (gdb) disassemble ADDR     -> regular assembly listing
> >    (gdb) disassemble /s ADDR  -> intermixed source+assembly listing
> > 
> > Is that OK with everyone? It's pretty consistent with what we do
> > for the print command, so I like it.
> 
> I think using a '/' modifier is good, since that's what 
> we use for print and examine and so on.
> 
> The choice of the letter 's' is probably as good as any.
> The only other one that comes to my mind is 'm' (for "mixed").
> And I'm not expressing a preference or objection.

OK, in the absence of further discussion, patch approved.

Doug, as the author, you get to choose the modifier flag.
;-)