This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Remove comments from user_code in gdb_test_multiple


Markus Deuling wrote:
What do you think about the spu info mailbox patch then ? Move the comment above gdb_test_multiple ? Or use send_gdb/gdb_expect and have the comments in the right place?

The (?#) directive allows you to put the comments inside the regular expression itself.


-re "(?#Older kernels had a bug that caused them to return arbitrary values when
attempting to read from an empty mailbox via spufs.
)SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*$gdb_prompt $"


Or, alternatively, the (?x) directive might be cleaner. Note that this changes the meaning of white space.

-re "(?x)
#Older kernels had a bug that caused them to return arbitrary values when
#attempting to read from an empty mailbox via spufs.
SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*
$gdb_prompt[ ]$"



This is untested!


Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]