This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix testsuite annotate-quit race (PR 544)

From: Nick Roberts <nickrob at snap dot net dot nz>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: bug-readline at gnu dot org, gdb-patches at sourceware dot org, Daniel Jacobowitz <drow at false dot org>
Date: Wed, 19 Mar 2008 20:46:25 +1200
Subject: Re: [patch] Fix testsuite annotate-quit race (PR 544)
References: <20080318225436.GA27374@host0.dyn.jankratochvil.net> <20080318231738.GA22432@caradoc.them.org> <20080319081056.GA32510@host0.dyn.jankratochvil.net>

 > > > PR 544 des gdb.cp/annota2.exp and gdb.cp/annota3.exp sometimes FAIL with:
 > > > 	FAIL: gdb.cp/annota3.exp: annotate-quit (pattern 1)
 > ...
 > > Isn't this a bug in GDB, not a bug in the test?
 > 
 > You are right it is probably better to fix it in readline.

Annotations are being deprecated and the original bug report is nearly six
years old.  As as variation of the old adage, I would suggest that "Since
no-one appears to mind it's broke, don't fix it".  The danger of making a fix
in readline, of course, is that you break annotations elsewhere, where it's
more important.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Follow-Ups:
- Re: [patch] Fix testsuite annotate-quit race (PR 544)
  - From: Jan Kratochvil

References:
- [patch] Fix testsuite annotate-quit race (PR 544)
  - From: Jan Kratochvil
- Re: [patch] Fix testsuite annotate-quit race (PR 544)
  - From: Daniel Jacobowitz
- Re: [patch] Fix testsuite annotate-quit race (PR 544)
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]