This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Remove deprecated_set_value_type (part 1)
- From: Daniel Jacobowitz <drow at false dot org>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: rob dot quill at gmail dot com, gdb-patches at sourceware dot org
- Date: Mon, 25 Feb 2008 20:20:37 -0500
- Subject: Re: Remove deprecated_set_value_type (part 1)
- References: <baf6008d0801202053w5aaa9ee1pf4cde2b15ec8fa53@mail.gmail.com> <20080129195506.GE9019@caradoc.them.org> <baf6008d0801300338n119405c1x9d6507001ea4e945@mail.gmail.com> <200801301804.m0UI4eWR018093@brahms.sibelius.xs4all.nl>
On Wed, Jan 30, 2008 at 07:04:40PM +0100, Mark Kettenis wrote:
> There are some code style problems here too, and although they're not
> your fault, it'd be nice to fix them while you're there. Actually, it
> looks to me as if the temparg variable is completely redundant now, so
> the above could be simplified to
>
> val = value_addr (val);
Mark's right; also, there are still formatting problems with the patch
that I commented on the last time I reviewed it :-( Rob, let me know if
you'd like me to point them out individually.
--
Daniel Jacobowitz
CodeSourcery