This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Bug in mips:3900 arch ?
- From: Markus Deuling <deuling at de dot ibm dot com>
- To: Daniel Jacobowitz <drow at false dot org>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 14 Feb 2008 07:11:42 +0100
- Subject: Re: Bug in mips:3900 arch ?
- References: <479DEAAA.4050108@de.ibm.com> <20080131222104.GC6715@caradoc.them.org>
Hi Daniel,
Daniel Jacobowitz schrieb:
On Mon, Jan 28, 2008 at 03:46:02PM +0100, Markus Deuling wrote:
> Yes, this looks like a bug. It is caused by the special case in
mips_gdbarch_init, by the comment:
/* Try the architecture for any hint of the correct ABI. */
I think replacing the internal error by "return" or "break" would be
safe. No real Linux application will ever have the EABI32 or EABI64
ABIs.
sorry for the late response. This patch simply removes the internal error. Maybe it would be a
good idea to add a warning instead? But as you say no Linux application will ever run into this
so the warning might be unnecessary.
Is this patch ok?
ChangeLog:
* mips-linux-tdep.c (mips_linux_init_abi): Remove internal error.
--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com
diff -urpN src/gdb/mips-linux-tdep.c dev/gdb/mips-linux-tdep.c
--- src/gdb/mips-linux-tdep.c 2008-01-01 23:53:12.000000000 +0100
+++ dev/gdb/mips-linux-tdep.c 2008-02-14 06:54:39.000000000 +0100
@@ -1149,7 +1149,6 @@ mips_linux_init_abi (struct gdbarch_info
tramp_frame_prepend_unwinder (gdbarch, &mips_linux_n64_rt_sigframe);
break;
default:
- internal_error (__FILE__, __LINE__, _("can't handle ABI"));
break;
}