This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] MI: lvalues and variable_editable
On Sat, Nov 03, 2007 at 10:22:56PM +1300, Nick Roberts wrote:
> + if (!(var->root->is_valid && var->value && VALUE_LVAL(var->value)))
> + return 0;
Space before parenthesis.
> /* FIXME: define masks for attributes */
> ! if (!varobj_editable_p (var))
> error (_("mi_cmd_var_assign: Variable object is not editable"));
> + else
> + {
> + expression = xstrdup (argv[1]);
No need to move all this code into an else; error will never return.
The patch seems fine to me, with Vladimir's comments.
--
Daniel Jacobowitz
CodeSourcery