This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: delete_breakpoint: don't try to insert other breakpoints


> From:  Vladimir Prus <ghost@cs.msu.su>
> Date:  Thu, 15 Nov 2007 08:59:19 +0300
> 
> > I think you are assuming that this code does and will always run
> > synchronously.  Is that a valid assumption?
> 
> At the moment, I'm not aware of any way to invoke delete_breakpoint
> while existing breakpoints are inserted. Is there one?
> (In particular, "target async" does not seem to work at all).
> 
> In future, this situation might be possible. However, in general 
> I think it's better to start by making code clear while still
> working for current GDB, and then adjust it as needed for future GDB.
> In this particular case, a call to insert_breakpoints, together
> with some adjustments, would be much better for any future async code,
> as it won't duplicate code logic.

I'm okay with making the code cleaner, but on at a price of removing
features, even if they are currently unused.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]