This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Watchpoints: support for thread <thread_num> parameters
- From: Eli Zaretskii <eliz at gnu dot org>
- To: luisgpm at linux dot vnet dot ibm dot com
- Cc: drow at false dot org, gdb-patches at sourceware dot org
- Date: Wed, 14 Nov 2007 00:29:35 +0200
- Subject: Re: [patch] Watchpoints: support for thread <thread_num> parameters
- References: <1187298178.5853.11.camel@localhost> <uwsvuv4re.fsf@gnu.org> <1187365616.4520.14.camel@localhost> <20071011193558.GE30810@caradoc.them.org> <1192134591.18528.1.camel@localhost> <1194961811.4820.3.camel@localhost>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Luis Machado <luisgpm@linux.vnet.ibm.com>
> Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
> Date: Tue, 13 Nov 2007 11:50:11 -0200
>
> Here is the patch together with the testcase and the documentation bits.
Thanks!
> Please let me know if there are any improvements/corrections suitable
> for this one.
The documentation part is okay with me, provided that you fix the
following two small gotchas:
> +@item watch @var{expr} thread thread_num
thread_num should be in @var here. Also, I'd suggest to use threadnum
or just num, to avoid the underscore (that doesn't go well together
with the @var markup).
> +Set a watchpoint that will break when @var{expr} is either read from
> +or written into by the thread identified by @var{thread_num}. If @var{expr}
^^
> +is modified by any other threads not matching @var{thread_num}, @value{GDBN}
> +will not break. Note that this will only work with Hardware Watchpoints.
^^
Two spaces after a period that ends a sentence, please.