This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] printf support for DFP values
- From: Daniel Jacobowitz <drow at false dot org>
- To: Luis Machado <luisgpm at linux dot vnet dot ibm dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Thu, 1 Nov 2007 11:34:18 -0400
- Subject: Re: [PATCH] printf support for DFP values
- References: <1193449497.6950.22.camel@localhost> <ubqaksyin.fsf@gnu.org> <1193669215.4800.10.camel@localhost> <ur6jdr8iy.fsf@gnu.org> <20071029201252.GA21583@caradoc.them.org> <upryxqmb5.fsf@gnu.org> <ulk9lqlmm.fsf@gnu.org> <1193753649.4283.5.camel@localhost> <uir4oqs3w.fsf@gnu.org> <1193879919.4994.2.camel@localhost>
Your most recent message was missing the revised patch, so I'm
replying to an older one. I was going to complain aobut some debug
printfs, but you seem to have fixed them already.
On Wed, Oct 31, 2007 at 10:18:39PM -0300, Luis Machado wrote:
> +#if defined (PRINTF_HAS_DECFLOAT)
> + printf_filtered(current_substring, dfp_value_ptr);
> +#else
Here and a couple of other places in the patch, please remember the
space before a left parenthesis.
> +AC_CACHE_CHECK([for decfloat support in printf],
> + gdb_cv_printf_has_decfloat,
> + [AC_RUN_IFELSE([AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT],
Boo, more run checks in configure :-( I cross-compile most of my
GDBs so run checks do not work. Well, this is not a new problem.
Rest looks fine to me too.
--
Daniel Jacobowitz
CodeSourcery