This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] printf support for DFP values


Your most recent message was missing the revised patch, so I'm
replying to an older one.  I was going to complain aobut some debug
printfs, but you seem to have fixed them already.

On Wed, Oct 31, 2007 at 10:18:39PM -0300, Luis Machado wrote:
> +#if defined (PRINTF_HAS_DECFLOAT)
> +	      printf_filtered(current_substring, dfp_value_ptr);
> +#else

Here and a couple of other places in the patch, please remember the
space before a left parenthesis.

> +AC_CACHE_CHECK([for decfloat support in printf],
> +               gdb_cv_printf_has_decfloat,
> +               [AC_RUN_IFELSE([AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT],

Boo, more run checks in configure :-(  I cross-compile most of my
GDBs so run checks do not work.  Well, this is not a new problem.

Rest looks fine to me too.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]