Re: [RFA] gdb_ari.sh patch to eliminate wrong critical errors

['Daniel Jacobowitz' <drow at false dot org>]

On Wed, Oct 10, 2007 at 10:09:18AM +0200, Pierre Muller wrote:
>   I tested this locally and it does reduce the 
> number of critical entries to 4.
>   
>   Daniel, could you please commit this?

Done.

>   Remaining problems are:
> 1) inline	9	Do not use the inline attribute; 
> since the compiler generally ignores this, better 
> algorithm selection is needed to improved performance
>   This problem is limited to three files:
> vec.c (1) vec.h (7) and xtensa-tdep.c (1).
> It could be easily removed, but I was wondering if 
> there was a special reason why vec.h 
> had some many.

No really good reason.  The above is someone's particular opinion on
the inline keyword (probably Andrew's, as he wrote the ARI stuff, but
I don't know for sure who - maybe someone else on the list knows).
vec.c / vec.h were written by Nathan for GCC, and the GCC project has
a very different opinion on the use of the inline keyword.

Perhaps the fact that the compiler sources think inline is worthwhile
should give us a hint...

> 3) hash	3	Do not use ` #...', instead use `#...'
> (some compilers only correctly parse a C preprocessor directive 
> when `#' is the first character on the line)
>   This 3 appearances are in:
>   ada-lex.c (2) and xtensa-tdep.c (1)
>   But ada-lex.c is an automatically generated file, and I am even wondering
> why 
> this file is checked.

Probably shouldn't be.

> 4) obsolete system	2	No config file for system
> These 2 entries are configure.host and configure.tgt
> which are again generated files...

No they aren't.  They're maintained by hand.

I can not figure out where this message comes from or what it means.

-- 
Daniel Jacobowitz
CodeSourcery