2007-06-28 Michael Snyder * mi/mi-cmd-var.c (mi_cmd_var_set_format): Eliminate unnecessary xstrdup. Index: mi/mi-cmd-var.c =================================================================== RCS file: /cvs/src/src/gdb/mi/mi-cmd-var.c,v retrieving revision 1.33 diff -p -r1.33 mi-cmd-var.c *** mi/mi-cmd-var.c 13 Jun 2007 19:08:47 -0000 1.33 --- mi/mi-cmd-var.c 29 Jun 2007 04:27:28 -0000 *************** mi_cmd_var_set_format (char *command, ch *** 203,218 **** if (argc != 2) error (_("mi_cmd_var_set_format: Usage: NAME FORMAT.")); /* Get varobj handle, if a valid var obj name was specified */ var = varobj_get_handle (argv[0]); if (var == NULL) error (_("mi_cmd_var_set_format: Variable object not found")); ! formspec = xstrdup (argv[1]); ! if (formspec == NULL) ! error (_("mi_cmd_var_set_format: Must specify the format as: \"natural\", \"binary\", \"decimal\", \"hexadecimal\", or \"octal\"")); ! len = strlen (formspec); if (strncmp (formspec, "natural", len) == 0) --- 203,218 ---- if (argc != 2) error (_("mi_cmd_var_set_format: Usage: NAME FORMAT.")); + if (argv[1] == NULL) + error (_("mi_cmd_var_set_format: Must specify the format as: \"natural\", \"binary\", \"decimal\", \"hexadecimal\", or \"octal\"")); + /* Get varobj handle, if a valid var obj name was specified */ var = varobj_get_handle (argv[0]); if (var == NULL) error (_("mi_cmd_var_set_format: Variable object not found")); ! formspec = argv[1]; len = strlen (formspec); if (strncmp (formspec, "natural", len) == 0)