2007-06-28 Michael Snyder * mi/mi-cmd-var.c (mi_cmd_var_set_format): Free strduped memory (Coverity). Also take the opportunity to call error earlier (before strdup). Index: mi/mi-cmd-var.c =================================================================== RCS file: /cvs/src/src/gdb/mi/mi-cmd-var.c,v retrieving revision 1.33 diff -p -r1.33 mi-cmd-var.c *** mi/mi-cmd-var.c 13 Jun 2007 19:08:47 -0000 1.33 --- mi/mi-cmd-var.c 29 Jun 2007 02:52:39 -0000 *************** mi_cmd_var_set_format (char *command, ch *** 209,218 **** if (var == NULL) error (_("mi_cmd_var_set_format: Variable object not found")); ! formspec = xstrdup (argv[1]); ! if (formspec == NULL) error (_("mi_cmd_var_set_format: Must specify the format as: \"natural\", \"binary\", \"decimal\", \"hexadecimal\", or \"octal\"")); len = strlen (formspec); if (strncmp (formspec, "natural", len) == 0) --- 209,220 ---- if (var == NULL) error (_("mi_cmd_var_set_format: Variable object not found")); ! if (argv[1] == NULL) error (_("mi_cmd_var_set_format: Must specify the format as: \"natural\", \"binary\", \"decimal\", \"hexadecimal\", or \"octal\"")); + formspec = xstrdup (argv[1]); + make_cleanup (xfree, formspec); + len = strlen (formspec); if (strncmp (formspec, "natural", len) == 0)