This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[MI] lvalues and variable_editable


I've been wondering what the difference is between varobj_value_is_changeable_p
and variable_editable.  Recent discussion on the gdb mailing list makes
me think that, in essence, a value is only changeable but not editable when
it's an lvalue -- but currently varobj.c doesn't capture this difference.

Here are two experimental patches:

1) varobj.c: Test if the value of variable object is an lvalue.  I think this
   can only occur for root values.

2) mi-cmd-var.c: Output a field with -var-create and -var-list-children
   when noneditable.

The testsuite only needs to change for 2).

It would seem sensible to define variable_editable using
varobj_value_is_changeable_p and I don't think language dependent versions
aren't needed.

WDYT?

-- 
Nick                                           http://www.inet.net.nz/~nickrob



*** varobj.c	14 Apr 2007 21:51:29 +1200	1.89
--- varobj.c	26 Jun 2007 23:12:52 +1200	
*************** c_type_of_child (struct varobj *parent, 
*** 2131,2136 ****
--- 2131,2151 ----
  static int
  c_variable_editable (struct varobj *var)
  {
+   struct expression *exp;
+   struct value *value;
+ 
+   if (is_root_p (var))
+     {
+       if (!gdb_evaluate_expression (var->root->exp, &value))
+ 	{
+ 	  /* We cannot proceed without a valid expression. */
+ 	  xfree (exp);
+ 	  return 0;
+ 	}
+       if (!VALUE_LVAL(value))
+ 	return 0;
+     }
+ 
    switch (TYPE_CODE (get_value_type (var)))
      {
      case TYPE_CODE_STRUCT:


*** mi-cmd-var.c	14 Jun 2007 10:12:15 +1200	1.33
--- mi-cmd-var.c	26 Jun 2007 21:32:26 +1200	
*************** print_varobj (struct varobj *var, enum p
*** 66,71 ****
--- 66,74 ----
        xfree (type);
      }
  
+   if (!(varobj_get_attributes (var) & 0x00000001))
+     ui_out_field_string (uiout, "attr", "noneditable");
+ 
    if (varobj_get_frozen (var))
      ui_out_field_int (uiout, "frozen", 1);
  }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]