This is the mail archive of the
mailing list for the GDB project.
Re: For example only, updated Windows DLL support and gdbserver DLL support
Daniel Jacobowitz wrote:
On Mon, Jun 18, 2007 at 05:07:28PM -0400, Christopher Faylor wrote:
I have no objections to this with two exceptions:
- You use #ifdef __CYGWIN__ . That would be the only place in the file
where that is used. I don't see any reason for this unless your patch
is also going to allow native Windows support. If that is the case,
then maybe that part should be provided separately.
- You seemed to have gratuitously pulled out the code which deals with
cygwin exceptions into a separate function. I don't think this has
anything to do with solibs and probably shouldn't be part of any
Pedro, what do you remember about these? At least, I don't _think_ it
Guilty as charged.
The __CYGWIN__ came from copy/pasting from the gdbserver side of the
patch, where it is needed. It can be easily removed.
The gratuitousness is only apparent. Notice that the
cygwin_load_start/cygwin_load_end calculation moved from the
old solib_symbols_add into that new ignore_access_violation_p
function and now uses the master_so_list () to get at cygwin1.dll.
As I was touching the code, (and I was finding myself reindenting
that big comment, ) I thought of moving it out of handle_exception
to make it cleaner.