Re: [rfc] [2/2] Remove macros TARGET_{FLOAT,DOUBLE,LONG_DOUBLE}_{BIT|FORMAT}

[Markus Deuling <deuling at de dot ibm dot com>]

Ulrich Weigand wrote:
> Markus Deuling wrote:
>
> > Sorry. Attached is a rebased version that applies against current head :-)
>
> Thanks.  One more thing: I've found an inconsistency in the gdbarch.c /
> gdbarch.sh changes:
>
> > diff -urN src/gdb/gdbarch.c dev/gdb/gdbarch.c
> > --- src/gdb/gdbarch.c	2007-06-12 18:05:43.000000000 +0200
> > +++ dev/gdb/gdbarch.c	2007-06-12 18:07:23.000000000 +0200
> > @@ -373,7 +373,7 @@
> >                 struct gdbarch_tdep *tdep)
> >  {
> >    /* NOTE: The new architecture variable is named ``current_gdbarch''
> > -     so that macros such as TARGET_DOUBLE_BIT, when expanded, refer to
> > +     so that macros such as TARGET_ARCHITECTURE, when expanded, refer to
> >       the current local architecture and not the previous global
> >       architecture.  This ensures that the new architectures initial
> >       values are not influenced by the previous architecture.  Once
>
> > diff -urN src/gdb/gdbarch.sh dev/gdb/gdbarch.sh
> > --- src/gdb/gdbarch.sh	2007-06-12 18:05:43.000000000 +0200
> > +++ dev/gdb/gdbarch.sh	2007-06-12 18:07:23.000000000 +0200
> > @@ -1348,7 +1348,7 @@
> >                 struct gdbarch_tdep *tdep)
> >  {
> >    /* NOTE: The new architecture variable is named \`\`current_gdbarch''
> > -     so that macros such as TARGET_DOUBLE_BIT, when expanded, refer to
> > +     so that macros such as gdbarch_double_bit, when expanded, refer to
> >       the current local architecture and not the previous global
> >       architecture.  This ensures that the new architectures initial
> >       values are not influenced by the previous architecture.  Once
>
> I've now committed the patch with this fixed.
>
> Bye,
> Ulrich

Again, thank you very much :-)


--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com