This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[rfc] [2/8] Remove macros ADDRESS_CLASS_TYPE_FLAGS and ADDRESS_CLASS_TYPE_FLAGS_P


Hello,

this patch removes ADDRESS_CLASS_TYPE_FLAGS and ADDRESS_CLASS_TYPE_FLAGS_P macro from gdbarch.sh


ChangeLog:


	* gdbarch.sh (ADDRESS_CLASS_TYPE_FLAGS): Replace by
	gdbarch_address_class_type_flags.
	* dwarf2read.c (read_tag_pointer_type): Likewise.
	* gdbarch.sh (ADDRESS_CLASS_TYPE_FLAGS_P): Replace by
	gdbarch_address_class_type_flags_p.
	* dwarf2read.c (read_tag_pointer_type): Likewise.
	* gdbarch.c, gdbarch.h: Regenerate.



Is this ok to commit?

--
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com







diff -urN src_neu/gdb/dwarf2read.c dev_neu/gdb/dwarf2read.c
--- src_neu/gdb/dwarf2read.c	2007-06-06 05:21:54.000000000 +0200
+++ dev_neu/gdb/dwarf2read.c	2007-06-08 07:18:31.000000000 +0200
@@ -4559,11 +4559,12 @@
      length accordingly.  */
   if (TYPE_LENGTH (type) != byte_size || addr_class != DW_ADDR_none)
     {
-      if (ADDRESS_CLASS_TYPE_FLAGS_P ())
+      if (gdbarch_address_class_type_flags_p (current_gdbarch))
 	{
 	  int type_flags;
 
-	  type_flags = ADDRESS_CLASS_TYPE_FLAGS (byte_size, addr_class);
+	  type_flags = gdbarch_address_class_type_flags
+			 (current_gdbarch, byte_size, addr_class);
 	  gdb_assert ((type_flags & ~TYPE_FLAG_ADDRESS_CLASS_ALL) == 0);
 	  type = make_type_with_address_space (type, type_flags);
 	}
diff -urN src_neu/gdb/gdbarch.c dev_neu/gdb/gdbarch.c
--- src_neu/gdb/gdbarch.c	2007-06-08 05:38:50.000000000 +0200
+++ dev_neu/gdb/gdbarch.c	2007-06-08 07:17:09.000000000 +0200
@@ -676,21 +676,9 @@
   fprintf_unfiltered (file,
                       "gdbarch_dump: address_class_name_to_type_flags = <0x%lx>\n",
                       (long) current_gdbarch->address_class_name_to_type_flags);
-#ifdef ADDRESS_CLASS_TYPE_FLAGS_P
-  fprintf_unfiltered (file,
-                      "gdbarch_dump: %s # %s\n",
-                      "ADDRESS_CLASS_TYPE_FLAGS_P()",
-                      XSTRING (ADDRESS_CLASS_TYPE_FLAGS_P ()));
-#endif
   fprintf_unfiltered (file,
                       "gdbarch_dump: gdbarch_address_class_type_flags_p() = %d\n",
                       gdbarch_address_class_type_flags_p (current_gdbarch));
-#ifdef ADDRESS_CLASS_TYPE_FLAGS
-  fprintf_unfiltered (file,
-                      "gdbarch_dump: %s # %s\n",
-                      "ADDRESS_CLASS_TYPE_FLAGS(byte_size, dwarf2_addr_class)",
-                      XSTRING (ADDRESS_CLASS_TYPE_FLAGS (byte_size, dwarf2_addr_class)));
-#endif
   fprintf_unfiltered (file,
                       "gdbarch_dump: address_class_type_flags = <0x%lx>\n",
                       (long) current_gdbarch->address_class_type_flags);
diff -urN src_neu/gdb/gdbarch.h dev_neu/gdb/gdbarch.h
--- src_neu/gdb/gdbarch.h	2007-06-08 06:33:08.000000000 +0200
+++ dev_neu/gdb/gdbarch.h	2007-06-08 07:17:09.000000000 +0200
@@ -1049,30 +1049,11 @@
 extern int gdbarch_have_nonsteppable_watchpoint (struct gdbarch *gdbarch);
 extern void set_gdbarch_have_nonsteppable_watchpoint (struct gdbarch *gdbarch, int have_nonsteppable_watchpoint);
 
-#if defined (ADDRESS_CLASS_TYPE_FLAGS)
-/* Legacy for systems yet to multi-arch ADDRESS_CLASS_TYPE_FLAGS */
-#if !defined (ADDRESS_CLASS_TYPE_FLAGS_P)
-#define ADDRESS_CLASS_TYPE_FLAGS_P() (1)
-#endif
-#endif
-
 extern int gdbarch_address_class_type_flags_p (struct gdbarch *gdbarch);
-#if !defined (GDB_TM_FILE) && defined (ADDRESS_CLASS_TYPE_FLAGS_P)
-#error "Non multi-arch definition of ADDRESS_CLASS_TYPE_FLAGS"
-#endif
-#if !defined (ADDRESS_CLASS_TYPE_FLAGS_P)
-#define ADDRESS_CLASS_TYPE_FLAGS_P() (gdbarch_address_class_type_flags_p (current_gdbarch))
-#endif
 
 typedef int (gdbarch_address_class_type_flags_ftype) (int byte_size, int dwarf2_addr_class);
 extern int gdbarch_address_class_type_flags (struct gdbarch *gdbarch, int byte_size, int dwarf2_addr_class);
 extern void set_gdbarch_address_class_type_flags (struct gdbarch *gdbarch, gdbarch_address_class_type_flags_ftype *address_class_type_flags);
-#if !defined (GDB_TM_FILE) && defined (ADDRESS_CLASS_TYPE_FLAGS)
-#error "Non multi-arch definition of ADDRESS_CLASS_TYPE_FLAGS"
-#endif
-#if !defined (ADDRESS_CLASS_TYPE_FLAGS)
-#define ADDRESS_CLASS_TYPE_FLAGS(byte_size, dwarf2_addr_class) (gdbarch_address_class_type_flags (current_gdbarch, byte_size, dwarf2_addr_class))
-#endif
 
 extern int gdbarch_address_class_type_flags_to_name_p (struct gdbarch *gdbarch);
 
diff -urN src_neu/gdb/gdbarch.sh dev_neu/gdb/gdbarch.sh
--- src_neu/gdb/gdbarch.sh	2007-06-08 06:33:08.000000000 +0200
+++ dev_neu/gdb/gdbarch.sh	2007-06-08 07:17:59.000000000 +0200
@@ -655,7 +655,7 @@
 v:=:const char *:name_of_malloc:::"malloc":"malloc"::0:NAME_OF_MALLOC
 v::int:cannot_step_breakpoint:::0:0::0
 v::int:have_nonsteppable_watchpoint:::0:0::0
-F:=:int:address_class_type_flags:int byte_size, int dwarf2_addr_class:byte_size, dwarf2_addr_class
+F::int:address_class_type_flags:int byte_size, int dwarf2_addr_class:byte_size, dwarf2_addr_class
 M::const char *:address_class_type_flags_to_name:int type_flags:type_flags
 M::int:address_class_name_to_type_flags:const char *name, int *type_flags_ptr:name, type_flags_ptr
 # Is a register in a group



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]