This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: powerpc-linux biarch corefile support
- From: Daniel Jacobowitz <drow at false dot org>
- To: Alan Modra <amodra at bigpond dot net dot au>
- Cc: Mark Kettenis <mark dot kettenis at xs4all dot nl>, gdb-patches at sourceware dot org
- Date: Thu, 8 Feb 2007 09:40:17 -0500
- Subject: Re: powerpc-linux biarch corefile support
- References: <20070122164308.GF8686@bubble.grove.modra.org> <200701221711.l0MHBr7d028668@brahms.sibelius.xs4all.nl> <20070123065726.GG8686@bubble.grove.modra.org>
On Tue, Jan 23, 2007 at 05:27:26PM +1030, Alan Modra wrote:
> Yes, it is for zero extending, and also for initializing unused
> fields. Random values in unused fields (eg. orig_gpr3) look odd in
> core dumps. I could cure that particular problem by clearing the
> buffer in linux-nat.c:linux_nat_do_thread_registers, but that doesn't
> help ps_lgetregs.
Note, we use this very rarely now - libthread_db may call it internally
to get at the thread pointer, but we no longer use it to get at
registers for our own purposes.
> OK, and thanks for the review. How does this look?
FWIW, it looks fine to me, but it's hard to read a complete rewrite.
Mark, did you want to take a look at this revised patch?
--
Daniel Jacobowitz
CodeSourcery