This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [mi] kill release_value calls
- From: Daniel Jacobowitz <drow at false dot org>
- To: Vladimir Prus <ghost at cs dot msu dot su>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Wed, 24 Jan 2007 14:40:09 -0500
- Subject: Re: [mi] kill release_value calls
- References: <200701242233.30910.ghost@cs.msu.su>
On Wed, Jan 24, 2007 at 10:33:30PM +0300, Vladimir Prus wrote:
>
> This patch removes all calls to release_value in varobj.c, except
> for one. We only need to call release_value when we're storing
> a value for indefinite future use, and install_new_value is the
> only such place. The extra release_value calls either
> are time-consuming no-ops, or lead to memory leaks,
> depending on the value type.
>
> OK?
OK. My apologies to Nick - I'd told him this was wrong, but I was
mistaken.
--
Daniel Jacobowitz
CodeSourcery