This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] MI: Free values when updating
Nick Roberts wrote:
> > Index: varobj.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/varobj.c,v
> > retrieving revision 1.79
> > diff -u -p -r1.79 varobj.c
> > --- varobj.c 16 Jan 2007 02:12:49 -0000 1.79
> > +++ varobj.c 23 Jan 2007 09:12:07 -0000
> > @@ -1987,11 +1987,7 @@ c_value_of_root (struct varobj **var_han
> > /* We need to catch errors here, because if evaluate
> > expression fails we just want to make val->error = 1 and
> > go on */
>
> This comment is not applicable anymore.
It actually is -- the comment says why we use gdb_evaluate_expression,
as opposed to evaluate_expression. Only the part about val->error is obsolete,
and I'll fix that.
- Volodya