Re: [PATCH] Follow specific symbol's DW_AT_decl_file

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

On Sun, 21 Jan 2007 17:54:51 +0100, Daniel Jacobowitz wrote:
...
> /* This structure is space critical.  See space comments at the top.  */
> 
> So I wrote an implementation that used an on-the-side hash table.  But
> in the end, it was a bit slower, and most symbols needed one.  Even
> with -readnow the memory increase was only 3%, so it will be less than
> that in practice.  So I went back to doing it in the symbol after all
> :-)

Due to that comment I originally valgrind(1)ed it and on my testcase the memory
requirement increase was visible but negligible.


> The other changes I made were to move the index handling into
> dwarf2read.c, since the concept of a file index is dwarf specific,
> and to move the test into gdb.base, since in theory other debug
> formats could get it right.

Thanks, it unexpectedly cleaned up the patch a lot.


Regards,
Jan


> I tested this on x86_64-pc-linux-gnu and committed it.

(fine on local RH i686-pc-linux-gnu)