This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: MI - Detecting change of string contents with variable objects
> > I agree. Below is my latest patch, incorporating some of your
> > suggestions.
>
> This looks fine to me if it's fine with Vlad.
>
> > gdb_assert (!value_lazy (var->value));
> > ! gdb_assert (!value_lazy (value));
> > !
> > ! if (!value_contents_equal (var->value, value))
> > ! changed = 1;
>
> Why are you removing the second assert here?
Argh! Vladimir had the same question, I thought I'd put it back. I have now.
I've also used:
strcmp (var->print_value, print_value) != 0
since that method seems to be the norm in varobj.c, and GDB generally.
I've committed this change, which you might not like, because I think Vladimir
is agreeable to it. Of course, I'll make changes, including reversion, if
there are problems.
--
Nick http://www.inet.net.nz/~nickrob