This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] A few Cygwin testsuite fixes.


Daniel Jacobowitz escreveu:
On Sun, Dec 10, 2006 at 06:01:39PM +0000, Pedro Alves wrote:
Christopher Faylor escreveu:
On Sun, Dec 10, 2006 at 01:43:03PM +0000, Pedro Alves wrote:

I don't have the right to approve or commit this but I have to say that
while the logic looks ok, I don't think the name of the variable you're
using should be "DLLEXT".  A "DLL" is generally a windows thing.  Maybe
it should be SOEXT instead.
Thanks for taking a look. I had considered both, but, in the end I sticked
with DLLEXT, because I felt that the 'dynamic' in DLL goes more to the point, than
'shared' in SO goes. I can change that, no prob.


Attached is the updated/renamed patch.

Please review and commit.

Hi Pedro,


Do you want to go ahead with this or drop the $SOEXT portions (after
your ld patch)?


Sorry I didn't say anything here.


Well, after the ld patch is applied, there is no need for this for
Cygwin/MinGW/arm-wince anymore, so I am OK with dropping it.

Thanks,

Cheers,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]