This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2] Fix gdb.mi/mi-file.exp for stubs.
- From: Pedro Alves <pedro_alves at portugalmail dot pt>
- To: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 13 Dec 2006 23:25:55 +0000
- Subject: Re: [PATCH 2] Fix gdb.mi/mi-file.exp for stubs.
- References: <45808168.9010601@portugalmail.pt>
Pedro Alves escreveu:
Hi all,
There is a comment on mi-file.exp that says:
# get the path and absolute path to the current executable
#
# In gdb 6.2 (at least), the default line number is set by
# select_source_symtab to the first line of "main" minus
# the value of "lines_to_list" (which defaults to 10) plus one.
# --chastain 2004-08-13
That won't work for remote stubs.
The attached patch adds a call to mi_run_to_main with the following
comment:
# When debugging a stub, we can't depend on the current file
# being the default file set by select_source_symtab.
# When the gdb host connects to the stub, the stub will already be
# running the target program stopped at a function
# that probably isn't the one with main. We force
# the file with main to be the current, so the following tests work.
I withdraw this patch. It doesn't fix anything... I misread the
testresults. Sorry for the noise.
Instead, I propose skipping the test when running the testsuite against
a stub.
Also, the mi2-file.exp test has the same problem.
Please find a new patch attached, review and commit.
Cheers,
Pedro Alves
---
2006-12-13 Pedro Alves <pedro_alves@portugalmail.pt>
* gdb.mi/mi-file.exp: Skip test if use_gdb_stub is set.
* gdb.mi/mi2-file.exp: Likewise.
Index: mi-file.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-file.exp,v
retrieving revision 1.7
diff -u -p -r1.7 mi-file.exp
--- mi-file.exp 12 Sep 2006 20:11:42 -0000 1.7
+++ mi-file.exp 13 Dec 2006 23:21:31 -0000
@@ -25,6 +25,18 @@
# but to verify the correct output response to MI operations.
#
+if [target_info exists use_gdb_stub] {
+
+ # When debugging a stub, we can't depend on the current file
+ # being the default file set by select_source_symtab.
+ # When the gdb host connects to the stub, the stub will already be
+ # running the target program stopped at a function
+ # that probably isn't the one with main.
+
+ verbose "Skipping mi-file.exp."
+ continue
+}
+
load_lib mi-support.exp
set MIFLAGS "-i=mi"
Index: mi2-file.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-file.exp,v
retrieving revision 1.7
diff -u -p -r1.7 mi2-file.exp
--- mi2-file.exp 10 Aug 2006 05:27:21 -0000 1.7
+++ mi2-file.exp 13 Dec 2006 23:21:31 -0000
@@ -25,6 +25,18 @@
# but to verify the correct output response to MI operations.
#
+if [target_info exists use_gdb_stub] {
+
+ # When debugging a stub, we can't depend on the current file
+ # being the default file set by select_source_symtab.
+ # When the gdb host connects to the stub, the stub will already be
+ # running the target program stopped at a function
+ # that probably isn't the one with main.
+
+ verbose "Skipping mi-file.exp."
+ continue
+}
+
load_lib mi-support.exp
set MIFLAGS "-i=mi2"