This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Implement Cell BE SPU-specific vector type
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: deuling at de dot ibm dot com (Markus Deuling)
- Cc: gdb-patches at sourceware dot org (GDB Patches)
- Date: Wed, 13 Dec 2006 14:52:17 +0100 (CET)
- Subject: Re: [RFA] Implement Cell BE SPU-specific vector type
Hi Markus,
> there were problems with whitespaces in the last patch I posted, so here
> it is again.
I'm sorry, but this has exactly the same problems as last time ...
> * spu-tdep.c (spu_init_vector_type): New function.
> (spu_builtin_type_vec128.): New static variable.
> (spu_register_type): Return spu_builtin_type_vec128 as default.
> (_initialize_spu_tdep): Call spu_init_vector_type.
Otherwise the patch is OK, can you either re-send with a fixed mailer
or as attachment?
Some problems:
> @@ -84,7 +86,7 @@
> spu_register_type (struct gdbarch *gdbarch, int reg_nr)
> {
> if (reg_nr < SPU_NUM_GPRS)
> - return builtin_type_vec128;
> + return spu_builtin_type_vec128;
>
> switch (reg_nr)
> {
All context lines without - or + start out with one space too many.
> + struct type *type;
> +
> + type = init_composite_type ("__spu_builtin_type_vec128",
> TYPE_CODE_UNION);
Some lines are broken up ...
Maybe this
> Content-Type: text/plain; charset=ISO-8859-15; format=flowed
has something to do with the problem.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com