This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Patch for QUIT macro support
On Fri, Oct 13, 2006 at 06:22:39AM -0700, Fred Fish wrote:
> On Friday 13 October 2006 05:43, Fred Fish wrote:
> > To test a possible fix for this, I made the following change:
>
> OK, guess I should keep up with the gdb-patches list more, particularly
> before posting. :-)
>
> I see Nick Roberts just posted a patch a few hours earlier that
> addresses the issue of where quit_flag is set. It also occured to
> me after posting my quick and dirty patch that it probably wasn't
> necessary to jump all the way back into the event loop signal
> handling code, just simply continue to check for the quit_flag
> and call quit when it's set.
Do you mean the big async patch? If so it's still worth fixing this in
isolation. Otherwise, I must have missed a patch.
I may not have time to look at this for a while - I find the event loop
so confusing - but in the meantime, it's come up before:
http://sourceware.org/ml/gdb-patches/2003-08/msg00213.html
http://sourceware.org/ml/gdb-patches/2004-02/msg00530.html
http://sourceware.org/ml/gdb-patches/2004-05/msg00234.html
Maybe one of those threads will be enlightening on how it's "supposed"
to work.
--
Daniel Jacobowitz
CodeSourcery