This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Yes but when you use a linux hosted compiler for reading windows source fileDate: Tue, 10 Oct 2006 17:08:23 +0200 From: Denis PILAT <denis.pilat@st.com> Cc: Eli Zaretskii <eliz@gnu.org>
As discussed in thread http://sources.redhat.com/ml/gdb-patches/2006-10/msg00090.html
about the TUI that did not display windows source files,
I propose a patch that treats source files where end-of-line are '\r' only.
I think part of your patch is not needed: the Windows port of GDB should use the LSEEK_NOT_LINEAR branch of the code in find_source_lines, so the code you are patching doesn't need to consider the \r\n case.
Well, I thought reading your previous email on the other patch you just accepted
As for the \r case, don't such files fail in many more places? It looks like you need to test for \r in every place where we currently test for \n, or am I missing something?
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |