This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Correct irix5-nat.c's fetch_core_registers
- From: Daniel Jacobowitz <drow at false dot org>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 24 Jul 2006 15:49:14 -0400
- Subject: Re: [PATCH] Correct irix5-nat.c's fetch_core_registers
- References: <Pine.LNX.4.44.0607210948200.3182-100000@www.eyesopen.com>
On Fri, Jul 21, 2006 at 10:12:10AM -0600, Roger Sayle wrote:
> ! else if (mips_isa_regsize (current_gdbarch) == 4 &&
> ! core_reg_size == (2 * mips_isa_regsize (current_gdbarch)) * NUM_REGS)
> ! else /* mips_isa_regsize (current_gdbarch) == 4 */
> {
> /* This is a core file from a N32 executable, 64 bits are saved
> for all registers. */
This change doesn't make sense to me. If I'm missing something, could
you try to explain it again?
As far as I remember, Irix supports O32 executables. So at a minimum
the comment is wrong. I don't know if it dumps 32-bit or 64-bit
registers for O32 core files; I wouldn't be too surprised if it dumped
64-bit core files and just the comment needed fixing.
--
Daniel Jacobowitz
CodeSourcery