This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Sorry for not getting back to you on this. Never made it back here when reviewing patches in reverse. Trying in patch tracker order today.
On Thu, Nov 17, 2005 at 03:04:39PM +0000, Andrew STUBBS wrote:+/* Command tracing state. */ + +int source_verbose = 0; +int commandtrace = 0;
You've got two of these, but you always check them together. One variable and incrementing/decrementing the trace level around source would work too, right?
+ /* Is there a '-v' in the string somewhere? */ + if (args && (minusv = strstr(args,"-v")))
Is there any benefit to supporting this at the end? We've already got some other commands that are strictly command [options] [args], I think, or at least we do in MI; I would recommend following the same model here. If it starts with -v it's an option.
+ add_setshow_boolean_cmd ("commandtrace", no_class, &commandtrace, _("\
I don't feel too strongly about this, just personal bias, but how about
something other than run-together words for this? We have a lot of
those in the existing code e.g. remotetimeout, but we've been trying to
either use hyphens or use spaces and sub-menus lately, I think. Something like "set trace-commands". Or, alternatively "set debug
cli-commands".
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |