This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: MI: type prefixes for values
- From: Daniel Jacobowitz <drow at false dot org>
- To: Vladimir Prus <ghost at cs dot msu dot su>, gdb-patches at sources dot redhat dot com, Nick Roberts <nickrob at snap dot net dot nz>
- Date: Mon, 15 May 2006 12:53:54 -0400
- Subject: Re: MI: type prefixes for values
- References: <17427.54333.236860.258115@kahikatea.snap.net.nz> <dvemrm$al0$1@sea.gmane.org> <20060317191207.GA19068@nevyn.them.org> <dvliph$urc$1@sea.gmane.org> <20060324030332.GB2853@nevyn.them.org> <e00anu$f6m$1@sea.gmane.org> <20060324202056.GA26748@nevyn.them.org> <e12k8s$dci$1@sea.gmane.org> <e2scu2$vvn$1@sea.gmane.org> <20060505192535.GM31029@nevyn.them.org>
> 2006-05-05 Daniel Jacobowitz <dan@codesourcery.com>
>
> * valprint.c: Include "exceptions.h".
> (val_print): If something goes wrong while printing, supply an
> error message.
I have committed this.
On Sat, May 06, 2006 at 09:58:38PM +1200, Nick Roberts wrote:
> It looks like you're catching the error lower down (higher up?) which allows
> any other values to be printed. Right? I like this.
Exactly right - higher up vs lower down is a bit tricky since all of
this stuff is recursive, but probably higher up the call chain.
> > This patch doesn't touch the issue of type prefixes, leaving that to
> > deal with separately.
>
> If I'm reading this right, I have since realised that my patch to use
> common_val_print was no good because it only prints address and not values for
> things like references
Vladimir noticed that there's a deref_ref argument to common_val_print;
you passed zero, but if you pass one instead, it ought to do the right
thing.
Would you like to try the patch again with that change?
--
Daniel Jacobowitz
CodeSourcery