This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: copy-edit File-I/O section of manual


Eli Zaretskii wrote:

Thanks. However, could you please submit these as two separate
patches, one that fixes only the spelling and grammar, the other with
the rest?

You're basically asking me to throw out the work I did and start over. I don't think I'm motivated enough to want to do that.


> I'd like to understand the motivation for moving stuff
around, for starters.

There were three pieces I moved around. I moved the separate sections on the restrictions on isatty() and system() to the (respective) sections where the actual functions are documented, so that all the information is in one place instead of split in two different places. The third piece was the section on memory access, which I moved to the "Protocol specific representation of datatypes" section. Again, the motivation was to collect related information in one place.


Also, when you send the patch for spelling and grammar, please try not
to reformat lines, so that unmodified lines don't appear in the diffs.
The way you did it (refilling the paragraphs after changing them)
makes the diffs unnecessarily voluminous and hard to read.

I *did* avoid reformatting lines as much as possible. However, there were a lot of lines that needed some sort of edit or another, even though many of the changes were very minor. Rather than trying to make sense of the line-by-line diffs, I suggest that the right way to review this change is to apply them and proofread the resulting text. If you spot additional problems, let me know and I can provide a revised patch to address them.


-Sandra



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]