This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Enhanced language support for Modula-2


Jim Blandy <jimb@codesourcery.com> writes:

> Have you written ChangeLog entries for this?  Follow the format the
> other entries use.
> 
> In GDB code, each curly brace gets a line to itself.  I see a few
> sharing a line with an 'if' or 'else' in m2-valprint.c and
> m2-typeprint.c.

Hi Jim and Eli,

sure ok, have done..

> Also, all GNU code should fit in eighty columns.

ok, now fixed..

> I see some indentation problems in m2_val_print.  If you're using GNU
> Emacs, just hit M-C-q before the function's opening brace, and it'll
> take care of it.

yes I use emacs for most things.. but I hadn't come across this short
cut though.. very useful and I believe all is now fixed..

Attachment: cvsdiff.8
Description: enhanced Modula-2 mode for gdb

also enclosed is a proposed set of ChangeLog entries:

Attachment: ChangeLog
Description: ChangeLog entries

regards,
Gaius

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]