This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] Fix spurious mi-basics.exp failures
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: gdb-patches at sourceware dot org
- Date: Sat, 6 May 2006 03:19:32 +0200 (CEST)
- Subject: [PATCH] Fix spurious mi-basics.exp failures
Hello,
I'm seeing some FAILs in the mi-basics test case. They're apparently
caused by the expected output regexps in some of the mi_gdb_test
statements lacking the 'serial number' the MI output lines start with.
Most mi_gdb_test statments already contain that number, but the 202,
203, and 208 tests don't have it. Those are exactly the tests that
fail for me. Adding the numbers fixes the test.
Tested on s390-ibm-linux and s390x-ibm-linux.
OK for mainline?
ChangeLog:
* gdb.mi/mi-basics.exp: Add missing serial number to
expected output in some mi_gdb_test statements.
* gdb.mi/mi2-basics.exp: Likewise.
Index: gdb/testsuite/gdb.mi/mi-basics.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-basics.exp,v
retrieving revision 1.12
diff -c -p -r1.12 mi-basics.exp
*** gdb/testsuite/gdb.mi/mi-basics.exp 27 Sep 2005 22:39:01 -0000 1.12
--- gdb/testsuite/gdb.mi/mi-basics.exp 6 May 2006 00:55:38 -0000
*************** proc test_dir_specification {} {
*** 160,170 ****
set envirodir [string_to_regexp ${srcdir}/${subdir}]
mi_gdb_test "202-environment-directory ${srcdir}/${subdir}" \
! "\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory arg operation"
mi_gdb_test "203-environment-directory" \
! "\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory empty-string operation"
mi_gdb_test "204-environment-directory -r" \
--- 160,170 ----
set envirodir [string_to_regexp ${srcdir}/${subdir}]
mi_gdb_test "202-environment-directory ${srcdir}/${subdir}" \
! "202\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory arg operation"
mi_gdb_test "203-environment-directory" \
! "203\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory empty-string operation"
mi_gdb_test "204-environment-directory -r" \
*************** proc test_path_specification {} {
*** 223,229 ****
"environment-path no-args operation"
mi_gdb_test "208-environment-path $srcdir $objdir" \
! "\\\^done,path=\"$escapedsrcdir.$escapedobjdir.$orig_path\"" \
"environment-path dir1 dir2 operation"
mi_gdb_test "209-environment-path -r $objdir" \
--- 223,229 ----
"environment-path no-args operation"
mi_gdb_test "208-environment-path $srcdir $objdir" \
! "208\\\^done,path=\"$escapedsrcdir.$escapedobjdir.$orig_path\"" \
"environment-path dir1 dir2 operation"
mi_gdb_test "209-environment-path -r $objdir" \
Index: gdb/testsuite/gdb.mi/mi2-basics.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi2-basics.exp,v
retrieving revision 1.4
diff -c -p -r1.4 mi2-basics.exp
*** gdb/testsuite/gdb.mi/mi2-basics.exp 27 Sep 2005 22:39:03 -0000 1.4
--- gdb/testsuite/gdb.mi/mi2-basics.exp 6 May 2006 00:55:38 -0000
*************** proc test_dir_specification {} {
*** 161,171 ****
set envirodir [string_to_regexp ${srcdir}/${subdir}]
mi_gdb_test "202-environment-directory ${srcdir}/${subdir}" \
! "\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory arg operation"
mi_gdb_test "203-environment-directory" \
! "\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory empty-string operation"
mi_gdb_test "204-environment-directory -r" \
--- 161,171 ----
set envirodir [string_to_regexp ${srcdir}/${subdir}]
mi_gdb_test "202-environment-directory ${srcdir}/${subdir}" \
! "202\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory arg operation"
mi_gdb_test "203-environment-directory" \
! "203\\\^done,source-path=\"${envirodir}.\\\$cdir.\\\$cwd\"" \
"environment-directory empty-string operation"
mi_gdb_test "204-environment-directory -r" \
*************** proc test_path_specification {} {
*** 226,232 ****
"environment-path no-args operation"
mi_gdb_test "208-environment-path $srcdir $objdir" \
! "\\\^done,path=\"$escapedsrcdir.$escapedobjdir.$orig_path\"" \
"environment-path dir1 dir2 operation"
mi_gdb_test "209-environment-path -r $objdir" \
--- 226,232 ----
"environment-path no-args operation"
mi_gdb_test "208-environment-path $srcdir $objdir" \
! "208\\\^done,path=\"$escapedsrcdir.$escapedobjdir.$orig_path\"" \
"environment-path dir1 dir2 operation"
mi_gdb_test "209-environment-path -r $objdir" \
--
Dr. Ulrich Weigand
Linux on zSeries Development
Ulrich.Weigand@de.ibm.com