Re: Fix powerpc64-linux inferior function calls

[Alan Modra <amodra at bigpond dot net dot au>]

On Sun, Oct 02, 2005 at 06:31:18PM -0400, Daniel Jacobowitz wrote:
> > 	(elf_symfile_read): Read both static and dynamic symbols before
> > 	processing.  Call bfd_get_synthetic_symtab.
> 
> Why do we need to read both before processing either?

The powerpc64 get_synthetic_symtab will use both dynamic and static
symbol tables.  Handy when debugging stripped objects.  So both symbols
tables need to be read before calling bfd_get_synthetic_symtab.

>  I'm thinking of
> the patch I posted here:
>     http://sourceware.org/ml/gdb-patches/2005-06/msg00220.html           
> and pinged a few weeks ago.

Which I see you do in this patch too.  I didn't know about your patch
when I wrote mine..  The order of processing doesn't matter at all.
It just fell out that way in my patch.  Incidentally, why did you
need to fudge the synthetic syms?

+	  /* Synthetic symbols are not, strictly speaking, either local
+	     or global.  But we can treat them as global symbols, since
+	     they are effectively dynamic symbols.  */
+	  synth_symbol_table[i]->flags |= BSF_GLOBAL;

Seems like this should be done in bfd if necessary.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre