This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fix "too much information" bug w/ "info vector" on PowerPC

On Thu, Sep 01, 2005 at 04:06:08PM -0700, Jim Blandy wrote:
> Paul Gilliam <> writes:
> > Talking about spaces, tabs, and formatting, I noticed that some of the function prototypes in ppc-tdep.h are over 80 columns and 
> > real ugly.
> >
> > Here, for your consideration, are two patches to change that:  one uses a short-lived macro (ppc-tdep.patch) and the other uses a
> > typedef (newest.patch).
> If I were to use a typedef, I'd put it in gdbarch.h and call it
> gdb_retval_convention_t; there's nothing special about ppc-tdep.h's
> needs.
> The following is also legal C, Emacs-friendly, and
> enum return_value_convention (ppc_sysv_abi_return_value
>                               (struct gdbarch *gdbarch,
>                                struct type *valtype,
>                                struct regcache *regcache,
>                                gdb_byte *readbuf,
>                                const gdb_byte *writebuf));
> I used this once before, but Mark Kettenis declared it "weird" or
> something and asked me to take it out.  :) Be that as it may, I think
> it's better than the macro or the local typedef.

It is weird :-P

What's so wrong with

enum return_value_convention ppc_sysv_abi_return_value
  (struct gdbarch *, struct type *, struct regcache *,
   gdb_byte *, const gdb_byte *);

Daniel Jacobowitz
CodeSourcery, LLC

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]