This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] -data-list-changed-registers (Take 2)
> It looks like you're doing basically mi_out_rewind. There's already
> several of these in captured_mi_execute_command. They don't catch this
> because throw_exception takes us past them, all the way back to
> mi_execute_command.
>
> If we add an mi_out_rewind call right here:
> 1176 /* The command execution failed and error() was called
> 1177 somewhere */
>
> Then the problem goes away.
So, basically, it just needed one line fix! Hmm...I think I'll look at the
rest of the MI code before I start re-inventing it again.
>From mi_cmd_data_list_register_values, I removed:
if (!target_has_registers)
{
mi_error_message = xstrprintf ("mi_cmd_data_list_register_values: No registers.");
return MI_CMD_ERROR;
}
Why do you think it should stay?
Nick