This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[COMMIT] Eliminate printing of redundant messages from remote.c


I've just committed the patch appended below.

It simply deletes the calls to deprecated show_value_hack().  As
observed in a brief discussion on gdb@, the calls to
deprecated_show_value_hack() printed a subset of the information
provided by the existing call to show_packet_config_cmd().

The discussion on gdb@ starts here:

    http://sources.redhat.com/ml/gdb/2005-04/msg00041.html

This patch supercedes an alternate patch that I had written which also
eliminated deprecated_show_value_hack(), but preserved the printing of
the redundant message:

    http://sources.redhat.com/ml/gdb-patches/2005-04/msg00056.html

Kevin

	* remote.c (show_remote_protocol_vcont_packet_cmd )
	(show_remote_protocol_qSymbol_packet_cmd)
	(show_remote_protocol_P_packet_cmd)
	(show_remote_protocol_Z_software_bp_packet_cmd)
	(show_remote_protocol_Z_hardware_bp_packet_cmd)
	(show_remote_protocol_Z_write_wp_packet_cmd)
	(show_remote_protocol_Z_read_wp_packet_cmd)
	(show_remote_protocol_Z_access_wp_packet_cmd)
	(show_remote_protocol_binary_download_cmd)
	(show_remote_protocol_qPart_auxv_packet_cmd)
	(show_remote_protocol_p_packet_cmd ): Delete calls to
	deprecated_show_value_hack().

Index: remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.179
diff -u -p -r1.179 remote.c
--- remote.c	25 Mar 2005 20:39:45 -0000	1.179
+++ remote.c	15 Apr 2005 17:00:09 -0000
@@ -754,7 +754,6 @@ show_remote_protocol_vcont_packet_cmd (s
 				       struct cmd_list_element *c,
 				       const char *value)
 {
-  deprecated_show_value_hack (file, from_tty, c, value);
   show_packet_config_cmd (&remote_protocol_vcont);
 }
 
@@ -773,7 +772,6 @@ show_remote_protocol_qSymbol_packet_cmd 
 					 struct cmd_list_element *c,
 					 const char *value)
 {
-  deprecated_show_value_hack (file, from_tty, c, value);
   show_packet_config_cmd (&remote_protocol_qSymbol);
 }
 
@@ -793,7 +791,6 @@ show_remote_protocol_P_packet_cmd (struc
 				   struct cmd_list_element *c,
 				   const char *value)
 {
-  deprecated_show_value_hack (file, from_tty, c, value);
   show_packet_config_cmd (&remote_protocol_P);
 }
 
@@ -826,7 +823,6 @@ show_remote_protocol_Z_software_bp_packe
 					       struct cmd_list_element *c,
 					       const char *value)
 {
-  deprecated_show_value_hack (file, from_tty, c, value);
   show_packet_config_cmd (&remote_protocol_Z[Z_PACKET_SOFTWARE_BP]);
 }
 
@@ -842,7 +838,6 @@ show_remote_protocol_Z_hardware_bp_packe
 					       struct cmd_list_element *c,
 					       const char *value)
 {
-  deprecated_show_value_hack (file, from_tty, c, value);
   show_packet_config_cmd (&remote_protocol_Z[Z_PACKET_HARDWARE_BP]);
 }
 
@@ -858,7 +853,6 @@ show_remote_protocol_Z_write_wp_packet_c
 					    struct cmd_list_element *c,
 					    const char *value)
 {
-  deprecated_show_value_hack (file, from_tty, c, value);
   show_packet_config_cmd (&remote_protocol_Z[Z_PACKET_WRITE_WP]);
 }
 
@@ -874,7 +868,6 @@ show_remote_protocol_Z_read_wp_packet_cm
 					   struct cmd_list_element *c,
 					   const char *value)
 {
-  deprecated_show_value_hack (file, from_tty, c, value);
   show_packet_config_cmd (&remote_protocol_Z[Z_PACKET_READ_WP]);
 }
 
@@ -890,7 +883,6 @@ show_remote_protocol_Z_access_wp_packet_
 					     struct cmd_list_element *c,
 					     const char *value)
 {
-  deprecated_show_value_hack (file, from_tty, c, value);
   show_packet_config_cmd (&remote_protocol_Z[Z_PACKET_ACCESS_WP]);
 }
 
@@ -959,7 +951,6 @@ show_remote_protocol_binary_download_cmd
 					  struct cmd_list_element *c,
 					  const char *value)
 {
-  deprecated_show_value_hack (file, from_tty, c, value);
   show_packet_config_cmd (&remote_protocol_binary_download);
 }
 
@@ -978,7 +969,6 @@ show_remote_protocol_qPart_auxv_packet_c
 					    struct cmd_list_element *c,
 					    const char *value)
 {
-  deprecated_show_value_hack (file, from_tty, c, value);
   show_packet_config_cmd (&remote_protocol_qPart_auxv);
 }
 
@@ -996,7 +986,6 @@ show_remote_protocol_p_packet_cmd (struc
 				   struct cmd_list_element *c,
 				   const char *value)
 {
-  deprecated_show_value_hack (file, from_tty, c, value);
   show_packet_config_cmd (&remote_protocol_p);
 }
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]