This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Eliminate deprecated_show_value_hack from remote.c


On Wed, Apr 06, 2005 at 01:55:37PM -0700, Kevin Buettner wrote:
> The patch below eliminates all calls to deprecated_show_value_hack()
> from remote.c.
> 
> I considered adding the fprint_filtered() statement which is now in
> the new show_remote_protocol_packet_cmd() to show_packet_config_cmd(),
> but I found one other call to this latter function which didn't also
> want/need the value printed.  This is why I created a brand new
> function.
> 
> Comments?

> +  fprintf_filtered (file,
> +                    _("Current use of remote protocol `%s' (%s) is %s.\n"),
> +		    config->name, config->title, value);

Do you need the word "packet" here?  It looks like name will be simply
'p'.  Otherwise, thank you for doing this!

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]