This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: an i18n sample


Baurjan did not preserve the existing style of concatenation; he
changed it to be uniform, to the one I object to (for the reasons I
gave).  If you disagree with my reasons, then let's discuss that
instead of you executively overriding them.  Neither the GNU nor GDB
coding style expresses a preference here.  Baurjan and I both prefer
the concatenation style for aesthetic reasons and no one else chose to
express an opinion.

We've previously discussed this and in the end we each [hopefully] accepted that there were technical and aesthetic reasons both for and against each choice (the ``agree to disagree'').


For shorter one line strings, there's no reason to retain the old style. However, for longer multi-line strings, which need to be kept to 80 columns, and require other white space formatting, then the old style is easier (and even when it breaks -p).

Remember, the Objective is to just get the strings marked up and then with the minimum of effort. This isn't the time to be changing string styles.

Does that sound reasonable?

Andrew

PS: I was simply obliging Baurjan's request that his patch get committed.

PPS: Of course if someone were to add i18n wordwrap code that automatically split these paragraphs at convenient points, this whole debate would be mute.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]