This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC/hppa] Change handling of stubs in the return path
- From: Daniel Jacobowitz <drow at false dot org>
- To: Randolph Chung <randolph at tausq dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 6 Dec 2004 18:06:31 -0500
- Subject: Re: [RFC/hppa] Change handling of stubs in the return path
- References: <20041206223712.GQ6359@tausq.org>
On Mon, Dec 06, 2004 at 02:37:12PM -0800, Randolph Chung wrote:
> The following patch changes the behavior of the unwinder for hpux so
> that export stubs are not visible when unwinding the stack. this is
> desired for several reasons as discussed on this list recently:
>
> 1. it is less confusing to the user (and more consistent with how
> gdb used to work)
> 2. it improves the behavior for commands like "up" and "finish",
> because the user expects to return to the caller of the current
> function, not to a stub that was synthesized by the toolchain
>
> This fixes all the FAILs in funcargs.exp and some of the ones in
> callfuncs.exp (and possibly others, i haven't ran the whole test)
>
> Note that the stub unwinder is still there for the cases when we single
> step into a stub. There are some issues with the stub unwinder for HPUX
> as well, but I'll fix that separately.
>
> comments? is this ok?
Does this work OK when single stepping out of something, i.e. back into
a stub?
> +static void
> +hppa_hpux_unwind_adjust_stub(struct frame_info *next_frame, CORE_ADDR base,
> + struct trad_frame_saved_reg *saved_regs)
Formatting ;-)
--
Daniel Jacobowitz