This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA fix conversion of little-byte big-word floats to doublest
On Sat, Dec 04, 2004 at 11:58:54PM +0000, Richard Earnshaw wrote:
> On Sat, 04 Dec 2004 12:32:57 EST, Daniel Jacobowitz <drow@false.org>
> wrote:
> > On Sat, Dec 04, 2004 at 05:25:21PM +0000, Richard Earnshaw wrote:
> > > I've just been thinking.
> > >
> > > The current code (for both conversions to and from doublest) tries to work
> > > by normalizing the word order to match the byte order. This clearly makes
> > > things quite difficult when the number of words involved is variable.
> > >
> > > I think it would be a more tractable problem to change all this around so
> > > that the byte order is normalized to match the word order. This can be
> > > done by simply repeating a word-normalization step for each word in the
> > > value.
> > >
> > > Thoughts?
> >
> > That sounds good to me - much simpler.
>
> I withdraw my previous patch and substitute this one. This should also
> fix handling of mixed endian formats that are larger than 64 bits.
>
> Unlike the previous patch this one also correctly handles NaNs; though it
> appears that nothing in the testsuite currently tests this.
Yes, the revised patch is OK. Thanks.
--
Daniel Jacobowitz