This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa/symbol readers] Clean up setting symbols' names
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: Daniel Jacobowitz <drow at false dot org>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Mon, 16 Feb 2004 15:50:25 -0500
- Subject: Re: [rfa/symbol readers] Clean up setting symbols' names
- References: <20040216193453.GA1667@nevyn.them.org>
Daniel Jacobowitz writes:
> This patch does a couple of related things.
>
> 1. It adds a macro, SYMBOL_SET_LINKAGE_NAME, which is used to set a
> symbol's name when the name should not be demangled. Used for things like
> typedefs whose name comes from debug info. I did not change anything
> related to memory allocation when I did this - though in hpread I found a
> few inconsistencies.
>
> 2. It makes hpread use SYMBOL_SET_NAMES. It contained some fallback code
> to use the debug info if demangling failed; I've disabled it, because from
> the description it sounds like the right thing to do would be to fix the
> demangler instead. I can't tell whether the code is currently used or not,
> so I would appreciate HP/UX testing for this patch.
>
> In the process I also kill a couple of DEPRECATED_SYMBOL_NAME uses, and the
> redundant function add_psymbol_with_dem_name_to_list.
>
> No testsuite changes with DWARF2 or stabs+ on i386-linux. OK?
>
NO. There are way too many unrelated changes in this patch.
The changes to hpread to use SYMBOL_SET_NAMES should be
independent. However you are also changing the logic of the code in a
few places, not just mechanically replacing things. You are changing
printf's, deleting functions, etc etc. You say there are no regression
on i386-linux, did you test on hpux?
The objfiles and symfile changes are also logically separate.
The SYMBOL_SET_LINKAGE_NAME macro can also be a separate thing.
I shouldn't spend time reminding you of this.